Don't use constructor initialization for this.
DataTable dt = new DataTable();
using (var con = new SqlConnection(ConfigurationManager.ConnectionStrings["ConnectionString"].ConnectionString))
using (var cmd = new SqlCommand(" SELECT FName" +
" FROM EmployeeTable " +
" WHERE EmployeeId = @empId",
con))
{
cmd.Parameters.Add(new SqlParameter("@empId",empId));
try
{
con.open();
dt.Load(cmd.ExecuteReader());
}
catch(Exception) //BAD BAD BAD!!! Why are you doing this!
{
}
}
return dt;
Also why are you catching all exceptions and throwing them away, this is a horrible thing to. If you have a exception you think is going to be common first see if you can refactor your code to check the for the input values that would cause it and not have it thrown at all (perhaps even throw an ArgumentException
of your own), and if you can't do that then check for that specific exception, not every possible one.
与恶龙缠斗过久,自身亦成为恶龙;凝视深渊过久,深渊将回以凝视…