asp.net mvc - redirect to return url after login

Question

I have a link in my razor view like this:

 <a href="Home/Login?ReturnUrl=Disputes/Index"> disputes</a>

Inside my login's action method, I am using this:

 public ActionResult Login(string returnUrl) {
   if (string.IsNullOrEmpty(returnUrl) && Request.UrlReferrer != null)
         returnUrl = Server.UrlEncode(Request.UrlReferrer.PathAndQuery);

   if (Url.IsLocalUrl(returnUrl) && !string.IsNullOrEmpty(returnUrl))
   {
      ViewBag.ReturnURL = returnUrl;
   }

   return View();
 }

In view I am using this:

 @Html.Hidden("returnUrl",@Request.QueryString)

Then in post action method:

 public ActionResult LogOn(LogOnModel model, string returnUrl)
 {
   if (ModelState.IsValid)
   {
      if (membershipService.ValidateUser(model.UserName, model.Password, model.Type))
      {
         formsAuthenticationService.SignIn(model.UserName, model.RememberMe);
         SetUserInfo(model.UserName);

         string decodedUrl = "";
         if (!string.IsNullOrEmpty(returnUrl))
            decodedUrl = Server.UrlDecode(returnUrl);

         if (Url.IsLocalUrl(decodedUrl))                    
            return Redirect(decodedUrl);
         else
            return Redirect("Home", Index);

      }
   }
 }

It is redirecting to:/Disputes/Index but it should go to myApp/Disputes/Index where the url with query string is like this. /myApp/Home/Login?ReturnUrl=/Disputes/Index

How can I solve this issue?

Answer 1

I use a combination of the above suggestion and Request.UrlReferrer to get the previous location:

    public ActionResult LogOn(string returnUrl)
    {
        //So that the user can be referred back to where they were when they click logon
        if (string.IsNullOrEmpty(returnUrl) && Request.UrlReferrer != null)
            returnUrl = Server.UrlEncode(Request.UrlReferrer.PathAndQuery);

        if (Url.IsLocalUrl(returnUrl) && !string.IsNullOrEmpty(returnUrl))
        {
            ViewBag.ReturnURL = returnUrl;
        }
        return View();
    }

This way I don't have to put the location in the ActionLink.

I populate a hidden field in the login page using the ViewBag.ReturnURL. Then in the Login HTTPPost ActionResult I redirect the user to the location in the hidden field (if there is one):

    [HttpPost]
    public ActionResult LogOn(LogOnModel model, string returnUrl)
    {
        //returnURL needs to be decoded
        string decodedUrl = "";
        if (!string.IsNullOrEmpty(returnUrl))
            decodedUrl = Server.UrlDecode(returnUrl);

        //Login logic...

        if (Url.IsLocalUrl(decodedUrl))
        {
            return Redirect(decodedUrl);
        }
        else
        {
            return RedirectToAction("Index", "Home");
        }
    }