ios - EXC_BAD_ACCESS on custom UIView with custom XIB

Question

I'm developing an iOS 5+ app with latest SDK.

I have created a custom UIView (TopMenuView) with a custom XIB. On Interface Builder I have changed, on this XIB, UIView class to TopMenuView. I haven't set any File's Owner.

On TopMenuView.m I have:

- (id)initWithCoder:(NSCoder *)aDecoder
{
    self = [super initWithCoder:aDecoder];

    if (self)
    {
        NSLog(@"init with coder: %d", counter);
        counter++;
        // Add custom XIB
        NSArray *topMenuView = [[NSBundle mainBundle] loadNibNamed:@"TopMenuView"
                                                             owner:nil
                                                           options:nil];
        UIView *nv = [topMenuView objectAtIndex:0];

        [self addSubview:nv];
    }

    return self;
}

Using Interface Builder I have added a UIView to a UIViewController and changed this UIView class to TopMenuView.

But, when I run the app, I get this log message 4251 times: 2013-10-13 20:49:34.078 MyProject[470:c07] init with coder: 0

And then, I get an EXC_BAD_ACCESS here:

NSArray *topMenuView = [[NSBundle mainBundle] loadNibNamed:@"TopMenuView"
                                                             owner:nil
                                                           options:nil];

Answer 1

The reason it's calling the initWithCoder so many times is due to wrong class setup in your .xib file.

Make sure the Custom Class on the File's Owner is your custom UIView class:

And make sure the class on the root View is the default UIView:

And now this is all you need in your custom class (in Swift):

required init?(coder aDecoder: NSCoder) {
    super.init(coder: aDecoder)

    let view = NSBundle.mainBundle().loadNibNamed("TopMenuView", owner: self, options: nil)[0] as! UIView
    self.addSubview(view)
    view.frame = self.bounds
}