java - Wrong output trying to print a triangle

Question

I tried to print a pattern

* * * * *
* * * * 
* * *
* *
*

I wrote this code in java

public class Psttr {

    public static void main(String[] args) {
        // TODO Auto-generated method stub
        Scanner h=new Scanner(System.in);
        int n=h.nextInt();
        int x=n;
        int i=1;
        
        for( i=1;i<=n;i++);
        {
            for(int j=1;j<=x;j++) {
                System.out.print("*");  
            }
            x=x-1;
            System.out.println();
        }

    }

}

I didn't get the right output, always *****

Expected output:

* * * * *
* * * * 
* * *
* *
*

question from:https://stackoverflow.com/questions/66061738/wrong-output-trying-to-print-a-triangle

Answer 1

Your code is good, just get rid of the semicolon after the first cycle so it would be:

public class Psttr {

    public static void main(String[] args) {
        Scanner h=new Scanner(System.in);
        int n=h.nextInt();
        int x=n;
        for(int i=1;i<=n;i++){ // You can init "i" here
            for(int j=1; j<=x--; j++) {
                System.out.print("*");
            }
            x--; // You can use post-decrement (or pre, it's the same here)
            System.out.print("
");
        }
    }
} 

Also it seems you're quite new to programming so I added some little advice to write "better code"