eloquent - Laravel (5.7) query builder adding (redundant) 'is not null' to query's SQL

Question

Using Laravel 5.7, it seems Eloquent Query builder is adding a (redundant?) is not null - why is this?

Output - where opportunities.contact_id is not null seems to be unnecessary?

question from:https://stackoverflow.com/questions/65950501/laravel-5-7-query-builder-adding-redundant-is-not-null-to-querys-sql

Answer 1

File Illuminate/Database/Eloquent/Relations/HasOneOrMany.php:

/**
 * Set the base constraints on the relation query.
 *
 * @return void
 */
public function addConstraints()
{
    if (static::$constraints) {
        $this->query->where($this->foreignKey, '=', $this->getParentKey());

        $this->query->whereNotNull($this->foreignKey);
    }
}

This was the bug fix: https://github.com/laravel/framework/commit/1e80162e9a3a4c42a0079bd9f34e785197a66c07