Hangman game - how to do a "wrong guess" in c++?

Question

Closed. This question needs details or clarity. It is not currently accepting answers. question from:https://stackoverflow.com/questions/65925592/hangman-game-how-to-do-a-wrong-guess-in-c

Answer 1

apart from that your code is not complete, the actual errors are easy to spot:

1. You have two loops. The outer "while" loop and the inner "for" loop. Those both use "i" as index, so the inner "i" hides the outer. This is not a bug in itself, but easily leads to other errors, like in your program.

2. Your second "if", the one that checks for a wrong guess, is outside the "for" loop, which means that the "i" used is the outer one, and not the one you want to use.

3. The wrong guess code should trigger only if right guess has not. One way to do this is to introduce a helper variable

So with this in mind, it could be rewritten to:

int tries = 0;
while (tries < 999)                                       
    {
        //code
        
        bool guess_wrong = true;
        for (int i = 0; i < mot_secret.length(); i++) // to check each letter
        {
            if (choisi_ton_mot[i] == u_recherche) //guess right
            {
                guess_wrong = false
                mot_secret[i] = u_recherche; // if right change "-" to the right letter
                std::cout << "lettre trouver ! " << std::endl;
            }
        }
        if (guess_wrong)
        {
            std::cout << "rater !" << std::endl;
            faute++;
        }
...