phpspec test logic in constructor

Question

I have a logic like this

 public function __construct(DataFetcherInterface $fetcher, Alert $alert) {
   $this->data = $fetcher->getData();
   foreach($this->data as $info) {
       try {
           $fetcher->assoicateAddress($info);
       } catch (Exception $e) {
           $alert->sendAlert($info)
       }
   }
}

and I want to test logic here, for example if sendAlert() will be called in case of exception.

    public function it_should_throw_exception(
        DataFetcherInterface $fetcher,
        Alert $alert
    ): void {
        $fetcher->getData()->willReturn(
        // data here
        )->shouldBeCalled();
        
        $fetcher->assoicateAddress(
        // data here
       )->willThrow(Excpetion::class)->shouldBeCalled();

        $alert->sendAlert()->shouldBeCalled(
        // data here
       );

        $this->beConstructedWith($fetcher, $logger); // <== not sure how to do it here
    }

and it's not working, error:

 - it should throw exception
      some predictions failed:
      DataFetcherInterfaceP3:
        No calls have been made that match:
            DataFetcherInterfaceP3->getData()
          but expected at least one.

I know php spec is for TDD, and I should start from tests, but at the moment I start adding tests I already had some come, for new code I'll use TDD approach.

Is it a bad practice to have such logic in constructor?? I have other methods in the class as well, but I want it to be instantiated with all needed data, and I'm using Visitor pattern to get all data while initializing object

question from:https://stackoverflow.com/questions/65849005/phpspec-test-logic-in-constructor

Answer 1

Waitting for answers