c++ - Why do I get an infinite loop if I enter a letter rather than a number?

Question

This question already has answers here:

Answer 1

This is how basic_istream works. In your case when cin >> num1 gets wrong input - failbit is set and cin is not cleared. So next time it will be the same wrong input. To handle this correctly you can add check for correct input and clear&ignore cin in case of wrong input. For example:

    #include<limits>

    //user enters a number
    cout << "
Please enter a positive number and press Enter: 
";
    do {    
        while(!(cin >> num1)) {
            cout << "Incorrect input. Please try again.
";
            cin.clear();
            cin.ignore(numeric_limits<streamsize>::max(), '
');
        }
        if(num1 < 0) cout << "The number you entered is negative. Please enter a positive number to continue.
";
    } while(num1 < 0);