Change the DATEADD
from day to week. Hence, two changes:
dateadd(week, @LastXDays, l_update)
and
dateadd(week, (@LastXDays + 1), @MaxDate)
In this case, I would also rename the @LastXDays
variable to @LastXWeeks
.
CREATE PROCEDURE [dbo].[spGetPlayingTimeOfthepeoplesPerDay] @email NVARCHAR(50)
AS
BEGIN
SET NOCOUNT ON;
DECLARE @MinDate DATE
,@MaxDate DATE
,@LastXDays INT
SELECT @LastXWeeks = - 15
SELECT @MaxDate = peoples.l_update
FROM peoples
WHERE peoples.email = @email
DECLARE @test TABLE (
quantity VARCHAR(100)
,DATE DATE
,TimePerDay DECIMAL(5, 2)
);
WITH CTE
AS (
SELECT peoples.email
,peoples.l_update
,act.quantity
,act.starttime
,act.endtime
,act.duration AS [Totaltime]
FROM peoples
INNER JOIN MPeoples ON peoples.Id = MPeoples.parent_id
INNER JOIN slines ON MPeoples.id = slines.movesuser_id
INNER JOIN seg ON slines.id = seg.sline_id
INNER JOIN act ON seg.id = act.seg_id
WHERE act.quantity = 'playing'
AND (peoples.email = @email)
GROUP BY peoples.email
,act.quantity
,act.duration
,act.starttime
,act.endtime
,peoples.l_update
)
INSERT INTO @test (
quantity
,DATE
,TimePerDay
)
SELECT quantity
,Cast(starttime AS DATE) AS DATE
,SUM(datediff(second, starttime, endtime)) / 60.0 AS TimePerDay
FROM cte WITH (NOLOCK)
WHERE starttime >= dateadd(week, @LastXWeeks, l_update)
GROUP BY quantity
,cast(starttime AS DATE)
SELECT @MaxDate = @MaxDate
,@MinDate = dateadd(week, (@LastXWeeks + 1), @MaxDate);
WITH AllDates
AS (
SELECT @MinDate AS xDate
UNION ALL
SELECT Dateadd(Day, 7, xDate)
FROM AllDates AS ad
WHERE ad.xDate < @MaxDate
)
SELECT 'playing' AS quantity
,ad.xDate
,Isnull(t.TimePerDay, 0) AS TimePerDay
FROM AllDates AS ad WITH (NOLOCK)
LEFT JOIN @test AS t ON ad.xDate = t.DATE
END
Also, a piece of advice: don't use query hints (NOLOCK
) if you do not understand their use. In this case, using NOLOCK
can have disastrous effects on your results.
Here are a few articles which you should read before deciding if you are going to keep using NOLOCK
or not.
Understanding the SQL Server NOLOCK hint
Bad habits : Putting NOLOCK everywhere