Welcome to OGeek Q&A Community for programmer and developer-Open, Learning and Share
Welcome To Ask or Share your Answers For Others

Categories

0 votes
738 views
in Technique[技术] by (71.8m points)

c - why am i getting segmentation fault in this?

I am supposed to print product of two numbers recursively. this is my code :

    #include<stdio.h>
int prod(int num1,int num2)
{
    if(num2=0)
    return num1;
    prod(num1+num1,num2-1);
}
int main()
{
    int n1,n2;
    printf("Enter two numbers to find their product:
");
    scanf("%d" ,&n1);
    scanf("%d" ,&n2);
    printf("Product of %d and %d is %d",n1,n2,prod(n1,n2));
    return 0;
}

This is a simple code but why am i getting segmentation fault? please help.

See Question&Answers more detail:os

与恶龙缠斗过久,自身亦成为恶龙;凝视深渊过久,深渊将回以凝视…
Welcome To Ask or Share your Answers For Others

1 Reply

0 votes
by (71.8m points)

Two problems:

  • You need a compare, not an assign operator.
  • You need to return the recursive call.

See below:

int prod(int num1,int num2)
{
    if(num2 == 0)
        return num1;
    return prod(num1+num1,num2-1);
}

与恶龙缠斗过久,自身亦成为恶龙;凝视深渊过久,深渊将回以凝视…
OGeek|极客中国-欢迎来到极客的世界,一个免费开放的程序员编程交流平台!开放,进步,分享!让技术改变生活,让极客改变未来! Welcome to OGeek Q&A Community for programmer and developer-Open, Learning and Share
Click Here to Ask a Question

1.4m articles

1.4m replys

5 comments

57.0k users

...