methods - Why doesn't my equality comparison using = (a single equals) work correctly in Java?

Question

I have a syntax error in the following line. However I can't understand what is the reason of this error.

if (address1.compareTo(address2) = 1)
        System.out.println(address1 + " is greater than " + address2);

What I want to achieve is printing proper message if and only if compareTo returns 1.

Answer 1

You should compare (==) instead of assigning (=). It can be very dangerous! To avoid such situations you can use Yoda notation so instead of comparing

address1.compareTo(address2) == 1

You can compare:

1 == address1.compareTo(address2)

In case of missing =, there will be comparation error.

In your case, it would be better to compare:

address1.compareTo(address2) > 0